-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31127/
-----------------------------------------------------------

(Updated Feb. 17, 2015, 7:57 p.m.)


Review request for Sqoop.


Changes
-------

I've moved the testng dependency to the root pom, so that all modules see it.


Bugs: SQOOP-2109
    https://issues.apache.org/jira/browse/SQOOP-2109


Repository: sqoop-sqoop2


Description
-------

There has been several things that I had to fix in order to get this right:

* Shell packaging was pulling in all dependencies regardless of their scope, I 
had to manually switch it from "test" to "runtime"
* Common was directly depending on common-test without properly specifying 
testing scope
* Security module was completely missing dependency on com.bueust (that wasn't 
problem because 2) has pulled it in transitively)


Diffs (updated)
-----

  common/pom.xml 9e593b2 
  pom.xml d48389e 
  security/pom.xml e4e61cc 
  shell/pom.xml e48c86a 

Diff: https://reviews.apache.org/r/31127/diff/


Testing
-------

I've run the packaging target and the shell/lib directory size decreased from 
46MB to 28MB (almost a half!), excluding all the testing dependencies.


Thanks,

Jarek Cecho

Reply via email to