Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11#discussion_r10114812
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala 
---
    @@ -77,7 +74,6 @@ class PairRDDFunctions[K: ClassTag, V: ClassTag](self: 
RDD[(K, V)])
           partitioner: Partitioner,
           mapSideCombine: Boolean = true,
           serializerClass: String = null): RDD[(K, C)] = {
    -    require(mergeCombiners != null, "mergeCombiners must be defined") // 
required as of Spark 0.9.0
    --- End diff --
    
    why did you remove this? We want to require this here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to