ankursinglaadobe commented on code in PR #10: URL: https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/10#discussion_r2163277419
########## src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java: ########## @@ -671,7 +671,13 @@ private UpdateResult handleUpdate(final String resourceType, if (session.itemExists(nodePath)) { session.getItem(nodePath).remove(); } - path = nodePath + CONFIG_FILE_EXTENSION; + final int lastDot = nodePath.lastIndexOf('.'); Review Comment: I have added some Unit tests for the handle update method, most of them were failing prior to this fix. Also, opened a new JIRA issue for updating parent to 62: https://issues.apache.org/jira/browse/SLING-12839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org