kwin commented on code in PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/10#discussion_r2161383098
##########
src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java:
##########
@@ -671,7 +671,13 @@ private UpdateResult handleUpdate(final String
resourceType,
if (session.itemExists(nodePath)) {
session.getItem(nodePath).remove();
}
- path = nodePath + CONFIG_FILE_EXTENSION;
+ final int lastDot = nodePath.lastIndexOf('.');
Review Comment:
Can we have a unit test to prevent regressions and illustrate where the old
renaming failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
