jsedding commented on code in PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/11#discussion_r2073668377
##########
src/main/java/org/apache/sling/jcr/packageinit/impl/ExecutionPlanRepoInitializer.java:
##########
@@ -157,9 +156,12 @@ public void processRepository(SlingRepository
slingRepository) throws Exception
logger.info("No tasks found in execution plan - no
additional packages installed.");
}
- // save hashes to file for crosscheck on subsequent
startup to avoid double processing
- writer.write(String.valueOf(plan.hashCode()));
- writer.newLine();
+ if ( !hasSnapshot ) {
+ // save hashes to file for crosscheck on
subsequent startup to avoid double processing
+ // but always process SNAPSHOT packages
+ writer.write(String.valueOf(plan.hashCode()));
+ writer.newLine();
+ }
Review Comment:
I don't know. I am not sufficiently familiar with how execution plans work.
I am also not opposed to having a solution where all packages are reinstalled
in this case. It _should_ not matter, because installing packages without
snapshot qualifier should be a no-op. Of course, this is where hard to diagnose
problems can be born. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
