jsedding commented on code in PR #11:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/11#discussion_r2073649494


##########
src/main/java/org/apache/sling/jcr/packageinit/impl/ExecutionPlanRepoInitializer.java:
##########
@@ -157,9 +156,12 @@ public void processRepository(SlingRepository 
slingRepository) throws Exception
                             logger.info("No tasks found in execution plan - no 
additional packages installed.");
                         }
                         
-                        // save hashes to file for crosscheck on subsequent 
startup to avoid double processing
-                        writer.write(String.valueOf(plan.hashCode()));
-                        writer.newLine();
+                        if ( !hasSnapshot ) {
+                            // save hashes to file for crosscheck on 
subsequent startup to avoid double processing
+                            // but always process SNAPSHOT packages
+                            writer.write(String.valueOf(plan.hashCode()));
+                            writer.newLine();
+                        }

Review Comment:
   Does this mean that _all_ packages are reinstalled if a snapshot package is 
part of the execution plan?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to