?????? Proper handling of the shenyu-agent module.

Mon, 21 Mar 2022 20:38:23 -0700 

Hi Willem??xiaoyu
    Thank you for your reply and attention.
    I have placed a meeting email link in issue and pr. everyone 
can view the email content and learn more about it. If there is anything 
unclear, you are welcome to communicate at any time.
    issue: https://github.com/apache/incubator-shenyu/issues/3064
    pr:https://github.com/apache/incubator-shenyu/pull/3073
    mail link: 
https://lists.apache.org/thread/ow8o0hkym6p72gsoxxk0pyk895yk4wzv
   think you.

    



------------------ ???????? ------------------
??????:                                                                         
                                               "dev"                            
                                                        <[email protected]&gt;;
????????:&nbsp;2022??3??22??(??????) ????10:54
??????:&nbsp;"dev"<[email protected]&gt;;

????:&nbsp;Re: Proper handling of the shenyu-agent module.



Hi Willem

Thank you for your enthusiastic reply and help.

His name wu ming participated in the conference[1].

as a participant in contributing agent logging rocketMQ[2]??

Because of the discussion at the meeting to remove the agent module.

So regarding logging rocketMQ in agent,

We decided to use shenyu's plugin ecosystem to refactor.

hi, hutaishi, Can you add a note in the pr with a link to the
conference so more people can learn about the backstory?


[1]: https://lists.apache.org/thread/ow8o0hkym6p72gsoxxk0pyk895yk4wzv
[2] https://github.com/apache/incubator-shenyu/pull/2887

Willem Jiang <[email protected]&gt; ??2022??3??22?????? 09:48??????
&gt;
&gt; Please add this background information and meeting minis link into the
&gt; github issue which lead to the PR??
&gt; it can save us lots of time for the average person who doesn't know
&gt; the background story.
&gt;
&gt;
&gt; Willem Jiang
&gt;
&gt; Twitter: willemjiang
&gt; Weibo: ????willem
&gt;
&gt; On Tue, Mar 22, 2022 at 8:41 AM hutaishi <[email protected]&gt; 
wrote:
&gt; &gt;
&gt; &gt; Hi Willem Jiang:
&gt; &gt; &amp;nbsp;&amp;nbsp;&amp;nbsp; There is a logging plugin under the 
agent module. Since we consider removing the agent module, we reconstruct the 
logging plugin under the agent module into Shenyu plugins.
&gt; &gt; &amp;nbsp;&amp;nbsp;&amp;nbsp; The metrics under the agent module are 
handled the same way.
&gt; &gt; &amp;nbsp;&amp;nbsp;&amp;nbsp; About tracing, Encourage developers to 
provide plugins to upstream like SkyWalking, ZipKin and OpenTelemetry to 
implement the tracing features.
&gt; &gt; &amp;nbsp;&amp;nbsp; metrics and logs belong to 
refactoring.&amp;nbsp; No other functional changes have been made, but an 
implementation method has been changed.
&gt; &gt; &amp;nbsp;&amp;nbsp; The community will improve observability step by 
step.
&gt; &gt; &amp;nbsp;&amp;nbsp; Thank you very much.
&gt; &gt;
&gt; &gt;
&gt; &gt;
&gt; &gt; &amp;nbsp;&amp;nbsp;
&gt; &gt;
&gt; &gt;
&gt; &gt;
&gt; &gt;
&gt; &gt;
&gt; &gt; ------------------&amp;nbsp;????????&amp;nbsp;------------------
&gt; &gt; 
??????:&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 
"dev"&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 <[email protected]&amp;gt;;
&gt; &gt; ????????:&amp;nbsp;2022??3??22??(??????) ????8:11
&gt; &gt; ??????:&amp;nbsp;"dev"<[email protected]&amp;gt;;
&gt; &gt;
&gt; &gt; ????:&amp;nbsp;Re: Proper handling of the shenyu-agent module.
&gt; &gt;
&gt; &gt;
&gt; &gt;
&gt; &gt; It is hard for me to understand the whole story just by going through
&gt; &gt; the github issue and this mail.
&gt; &gt; Could you add more context about it?
&gt; &gt; BTW, if we just want to send the message to the RocketMQ cluster, I
&gt; &gt; think we can provide a more general way to send messages through JMS
&gt; &gt; API.
&gt; &gt;
&gt; &gt; Willem Jiang
&gt; &gt;
&gt; &gt; Twitter: willemjiang
&gt; &gt; Weibo: ????willem
&gt; &gt;
&gt; &gt; On Mon, Mar 21, 2022 at 11:41 AM hutaishi 
<[email protected]&amp;gt; wrote:
&gt; &gt; &amp;gt;
&gt; &gt; &amp;gt; Hi Community:
&gt; &gt; &amp;gt; &amp;amp;nbsp;&amp;amp;nbsp;&amp;amp;nbsp;&amp;amp;nbsp; At 
the last meeting, we discussed the proper handling of agent modules.
&gt; &gt; &amp;gt; I removed the agent login module and added a logging 
rocketmq plug-in module.
&gt; &gt; &amp;gt; It belongs to refactoring type. Access logs??Include error 
log?? can be recorded and sent asynchronously to the rocketmq cluster.
&gt; &gt; &amp;gt;
&gt; &gt; &amp;gt;
&gt; &gt; &amp;gt; pr:https://github.com/apache/incubator-shenyu/pull/3073
&gt; &gt; &amp;gt; Please review the code so that I can improve it.
&gt; &gt; &amp;gt;
&gt; &gt; &amp;gt; think.

Reply via email to