Please add this background information and meeting minis link into the github issue which lead to the PR， it can save us lots of time for the average person who doesn't know the background story.
Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Mar 22, 2022 at 8:41 AM hutaishi <[email protected]> wrote: > > Hi Willem Jiang: > There is a logging plugin under the agent module. Since we > consider removing the agent module, we reconstruct the logging plugin under > the agent module into Shenyu plugins. > The metrics under the agent module are handled the same > way. > About tracing, Encourage developers to provide plugins to > upstream like SkyWalking, ZipKin and OpenTelemetry to implement the tracing > features. > metrics and logs belong to refactoring. No other > functional changes have been made, but an implementation method has been > changed. > The community will improve observability step by step. > Thank you very much. > > > > > > > > > > ------------------ 原始邮件 ------------------ > 发件人: > "dev" > > <[email protected]>; > 发送时间: 2022年3月22日(星期二) 上午8:11 > 收件人: "dev"<[email protected]>; > > 主题: Re: Proper handling of the shenyu-agent module. > > > > It is hard for me to understand the whole story just by going through > the github issue and this mail. > Could you add more context about it? > BTW, if we just want to send the message to the RocketMQ cluster, I > think we can provide a more general way to send messages through JMS > API. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Mon, Mar 21, 2022 at 11:41 AM hutaishi <[email protected]> wrote: > > > > Hi Community: > > &nbsp;&nbsp;&nbsp;&nbsp; At the last meeting, we > discussed the proper handling of agent modules. > > I removed the agent login module and added a logging rocketmq plug-in > module. > > It belongs to refactoring type. Access logs（Include error log） can be > recorded and sent asynchronously to the rocketmq cluster. > > > > > > pr:https://github.com/apache/incubator-shenyu/pull/3073 > > Please review the code so that I can improve it. > > > > think.
