cameronlee314 commented on a change in pull request #71: SAMZA-2437: Sample for 
producing to Azure Blob Storage
URL: https://github.com/apache/samza-hello-samza/pull/71#discussion_r371968280
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -206,6 +206,26 @@ under the License.
       <artifactId>guava</artifactId>
       <version>23.0</version>
     </dependency>
+    <!-- Jackson Dependencies -->
 
 Review comment:
   Does that mean that the azure library needs Jackson, but it does not pull it 
in transitively? That seems odd. Or maybe check if some other dependency is 
using a version of Jackson that is incompatible with the azure client.
   In any case, can you please add a comment about why this is necessary? It 
might be something you need to note on a user guide if there is one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to