lakshmi-manasa-g commented on a change in pull request #71: SAMZA-2437: Sample 
for producing to Azure Blob Storage
URL: https://github.com/apache/samza-hello-samza/pull/71#discussion_r371915951
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -206,6 +206,26 @@ under the License.
       <artifactId>guava</artifactId>
       <version>23.0</version>
     </dependency>
+    <!-- Jackson Dependencies -->
 
 Review comment:
   No the app does not need them directly.
   But azure-storage-blob depends on azure-core which in-turn needs Jackson.
   
   removing these dependencies throws 
   `java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/TSFBuilder
           at 
com.fasterxml.jackson.dataformat.xml.XmlMapper.<init>(XmlMapper.java:122) 
~[jackson-dataformat-xml-2.10.0.jar:2.10.0]
           at 
com.azure.core.implementation.serializer.jackson.JacksonAdapter.<init>(JacksonAdapter.java:75)
 ~[azure-core-1.0.0.jar:?]
           at 
com.azure.core.implementation.serializer.jackson.JacksonAdapter.createDefaultSerializerAdapter(JacksonAdapter.java:108)
 ~[azure-core-1.0.0.jar:?]
           at 
com.azure.core.implementation.RestProxy.createDefaultSerializer(RestProxy.java:629)
 ~[azure-core-1.0.0.jar:?]
           at 
com.azure.core.implementation.RestProxy.create(RestProxy.java:691) 
~[azure-core-1.0.0.jar:?]
           at 
com.azure.storage.blob.implementation.ServicesImpl.<init>(ServicesImpl.java:58) 
~[azure-storage-blob-12.0.1.jar:?]
           at 
com.azure.storage.blob.implementation.AzureBlobStorageImpl.<init>(AzureBlobStorageImpl.java:213)
 ~[azure-storage-blob-12.0.1.jar:?]
           at 
com.azure.storage.blob.implementation.AzureBlobStorageBuilder.build(AzureBlobStorageBuilder.java:90)
 ~[azure-storage-blob-12.0.1.jar:?]
           at 
com.azure.storage.blob.BlobServiceAsyncClient.<init>(BlobServiceAsyncClient.java:90)
 ~[azure-storage-blob-12.0.1.jar:?]
           at 
com.azure.storage.blob.BlobServiceClientBuilder.buildAsyncClient(BlobServiceClientBuilder.java:103)
 ~[azure-storage-blob-12.0.1.jar:?]
           at 
org.apache.samza.system.azureblob.producer.AzureBlobSystemProducer.setupAzureContainer(AzureBlobSystemProducer.java:370)
 ~[samza-azure_2.11-1.4.903-SNAPSHOT.jar:?]`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to