prateekm commented on a change in pull request #985: SAMZA-2155: Remove log4j
log4j2 dependency from samza-test
URL: https://github.com/apache/samza/pull/985#discussion_r272291959
##########
File path: build.gradle
##########
@@ -819,8 +819,6 @@ project(":samza-test_$scalaSuffix") {
compile project(":samza-core_$scalaSuffix")
compile project(":samza-kafka_$scalaSuffix")
compile project(":samza-sql_$scalaSuffix")
- runtime project(":samza-log4j_$scalaSuffix")
Review comment:
@rmatharu Actually logging to stdout is what we want, unless you think it'll
be better to have log files for tests. For that, we already have a testRuntime
dependency on slf4j-simple (console logger). My concern is that it will pick
log4j1 binding, find that the xml file is missing, and not log anything (like
you saw in the diagnostics repartitioner)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
