prateekm commented on a change in pull request #985: SAMZA-2155: Remove log4j log4j2 dependency from samza-test URL: https://github.com/apache/samza/pull/985#discussion_r272269026
########## File path: build.gradle ########## @@ -819,8 +819,6 @@ project(":samza-test_$scalaSuffix") { compile project(":samza-core_$scalaSuffix") compile project(":samza-kafka_$scalaSuffix") compile project(":samza-sql_$scalaSuffix") - runtime project(":samza-log4j_$scalaSuffix") Review comment: Do you need to exclude the slf4j-log4j12 (log4j1 binding) and slf4j-log4j-impl (log4j2 binding) from the dependencies? At least log4j1 binding currently comes transitively from several of the modules. If SLF4J picks it up and it finds that the log4j.xml is missing, it might not log to console. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services