prateekm commented on a change in pull request #984: Samza 2116: Making sink,
sendTo(table), sendTo(stream) non-terminal
URL: https://github.com/apache/samza/pull/984#discussion_r272252941
##########
File path:
samza-api/src/main/java/org/apache/samza/operators/functions/SinkFunction.java
##########
@@ -42,6 +42,6 @@
* @param messageCollector the {@link MessageCollector} to send the message
* @param taskCoordinator the {@link TaskCoordinator} to request commits or
shutdown
*/
- void apply(M message, MessageCollector messageCollector, TaskCoordinator
taskCoordinator);
+ M apply(M message, MessageCollector messageCollector, TaskCoordinator
taskCoordinator);
Review comment:
@bharathkk sink function is meath as an "escape hatch", in case something
isn't currently expressible in the high level API. We should already treat it
as a black-box. On second thought, might not be bad idea to let it return a
value, although in that case the new MessageStream should have the returned
value, not original. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
