prateekm commented on a change in pull request #984: Samza 2116: Making sink,
sendTo(table), sendTo(stream) non-terminal
URL: https://github.com/apache/samza/pull/984#discussion_r271985042
##########
File path:
samza-api/src/main/java/org/apache/samza/operators/functions/SinkFunction.java
##########
@@ -42,6 +42,6 @@
* @param messageCollector the {@link MessageCollector} to send the message
* @param taskCoordinator the {@link TaskCoordinator} to request commits or
shutdown
*/
- void apply(M message, MessageCollector messageCollector, TaskCoordinator
taskCoordinator);
+ M apply(M message, MessageCollector messageCollector, TaskCoordinator
taskCoordinator);
Review comment:
The sink _operator_ needs to return the original MessageStream it was
applied on. The function doesn't need to return anything
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
