dxichen commented on a change in pull request #950: SAMZA-2126: Bug fixes for batch-mode generated stream specs URL: https://github.com/apache/samza/pull/950#discussion_r264563956
########## File path: samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemFactoryJava.java ########## @@ -22,6 +22,7 @@ import org.apache.samza.config.ApplicationConfig; Review comment: I don't see any test that satisfy `kafka properties doesn't support replication.factor when creating topic` as per Jira description. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
