dxichen commented on a change in pull request #950: SAMZA-2126: Bug fixes for
batch-mode generated stream specs
URL: https://github.com/apache/samza/pull/950#discussion_r264562730
##########
File path:
samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemFactoryJava.java
##########
@@ -45,15 +46,13 @@ public void testGetIntermediateStreamProperties() {
// no properties for stream
config.put("streams.test.samza.intermediate", "true");
config.put("streams.test.compression.type", "lz4"); //some random config
- properties = JavaConversions.mapAsJavaMap(
- factory.getIntermediateStreamProperties(new MapConfig(config)));
- assertTrue(properties.isEmpty());
Review comment:
I think these lines should be able stay here, since they should be filtered
out as well but kafkaStreamSpec?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
