sborya commented on a change in pull request #938: SAMZA-1531: Support run.id
in standalone for batch processing.
URL: https://github.com/apache/samza/pull/938#discussion_r264474790
##########
File path:
samza-core/src/main/java/org/apache/samza/zk/ZkDistributedDataAccess.java
##########
@@ -0,0 +1,61 @@
+package org.apache.samza.zk;
+
+import org.apache.samza.coordinator.DistributedDataAccess;
+import org.apache.samza.coordinator.DistributedDataWatcher;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+public class ZkDistributedDataAccess implements DistributedDataAccess {
+ public static final Logger LOG =
LoggerFactory.getLogger(ZkDistributedDataAccess.class);
+ private final ZkUtils zkUtils;
+ private final ZkKeyBuilder keyBuilder;
+ private DistributedDataWatcher watcher;
+
+ public ZkDistributedDataAccess(ZkUtils zkUtils) {
+ if (zkUtils == null) {
+ throw new RuntimeException("Cannot operate ZkDistributedDataAccess
without ZkUtils.");
+ }
+ this.zkUtils = zkUtils;
+ this.keyBuilder = zkUtils.getKeyBuilder();
+ }
+
+ public Object readData(String key, DistributedDataWatcher watcher) {
Review comment:
Won't watcher override the one set in writeData? If they are the same (or
only one should be there) then make it final and pass it in the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
