sborya commented on a change in pull request #938: SAMZA-1531: Support run.id
in standalone for batch processing.
URL: https://github.com/apache/samza/pull/938#discussion_r264469347
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
##########
@@ -77,23 +95,80 @@
*/
public LocalApplicationRunner(SamzaApplication app, Config config) {
this.appDesc = ApplicationDescriptorUtil.getAppDescriptor(app, config);
- this.planner = new LocalJobPlanner(appDesc);
+ this.coordinationUtils = getCoordinationUtils(config);
+ getRunId();
+ this.planner = new LocalJobPlanner(appDesc, coordinationUtils, uid, runId);
}
/**
* Constructor only used in unit test to allow injection of {@link
LocalJobPlanner}
*/
@VisibleForTesting
- LocalApplicationRunner(ApplicationDescriptorImpl<? extends
ApplicationDescriptor> appDesc, LocalJobPlanner planner) {
+ LocalApplicationRunner(ApplicationDescriptorImpl<? extends
ApplicationDescriptor> appDesc, LocalJobPlanner planner, CoordinationUtils
coordinationUtils) {
this.appDesc = appDesc;
this.planner = planner;
+ this.coordinationUtils = coordinationUtils;
+ }
+
+ private CoordinationUtils getCoordinationUtils(Config config) {
+ JobCoordinatorConfig jcConfig = new JobCoordinatorConfig(config);
+ String coordinationId = new ApplicationConfig(config).getGlobalAppId() +
APPLICATION_RUNNER_PATH_SUFFIX;
+ return
jcConfig.getCoordinationUtilsFactory().getCoordinationUtils(coordinationId,
uid, config);
+ }
+
+ private void getRunId(){
+ Boolean isAppModeBatch = new
ApplicationConfig(appDesc.getConfig()).getAppMode() ==
ApplicationConfig.ApplicationMode.BATCH;
+ if(coordinationUtils == null || !isAppModeBatch) {
+ return;
+ }
+
+ runIdLock = coordinationUtils.getReadWriteLock(RUNID_LOCK_ID);
+ if(runIdLock == null) {
+ LOG.warn("Processor {} failed to create the lock for run.id generation",
uid);
Review comment:
better to find more specific info than UID, uid is not very helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
