cameronlee314 commented on a change in pull request #947: SAMZA-2120: Enable
custom handling of ConsumerRecords consumed by Kafka
URL: https://github.com/apache/samza/pull/947#discussion_r264368204
##########
File path:
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaConsumerProxy.java
##########
@@ -51,7 +53,7 @@
* This class is not thread safe. There will be only one instance of this
class per KafkaSystemConsumer object.
* We still need some synchronization around kafkaConsumer. See pollConsumer()
method for details.
*/
-class KafkaConsumerProxy<K, V> {
+public class KafkaConsumerProxy<K, V> {
Review comment:
The <K, V> does get used for the kafka `Consumer` which is wired in.
Ultimately, it doesn't get used since `IncomingMessageEnvelope` doesn't have
type params, but it looks like it helps to ensure the wiring matches up for the
proxy and Samza/Kafka consumer objects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
