cameronlee314 commented on a change in pull request #947: SAMZA-2120: Enable
custom handling of ConsumerRecords consumed by Kafka
URL: https://github.com/apache/samza/pull/947#discussion_r264368454
##########
File path:
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaConsumerProxy.java
##########
@@ -310,11 +312,7 @@ private void fetchMessages() {
results.put(ssp, messages);
}
- K key = record.key();
- Object value = record.value();
- IncomingMessageEnvelope imEnvelope =
- new IncomingMessageEnvelope(ssp, String.valueOf(record.offset()),
key, value, getRecordSize(record),
- record.timestamp(), Instant.now().toEpochMilli());
+ IncomingMessageEnvelope imEnvelope = handleNewRecord(record, ssp);
Review comment:
Renamed to `incomingMessageEnvelope`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
