cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934#discussion_r262185951
########## File path: samza-core/src/main/java/org/apache/samza/context/JobContextMetadata.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.context; + +import org.apache.samza.job.model.JobModel; +import org.apache.samza.system.StreamMetadataCache; + +import java.util.HashMap; +import java.util.Map; + +public class JobContextMetadata { Review comment: Apologies for missing this earlier: I just realized that the `objectRegistry` is specific to each task here, not the whole job. Therefore, could you please name this object (and its usages) to something that reflects the task scope? Maybe `InternalTaskContext`, since it is not part of the Samza public API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
