cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934#discussion_r262182936
########## File path: samza-core/src/main/java/org/apache/samza/context/JobContextMetadata.java ########## @@ -44,11 +42,14 @@ public Object fetchObject(String name) { return this.objectRegistry.get(name); } - public JobModel getJobModel() { - return this.jobModel; + public Context getContext() { + return context; } + public JobModel getJobModel() { + return ((TaskContextImpl) this.context.getTaskContext()).getJobModel(); + } public StreamMetadataCache getStreamMetadataCache() { Review comment: Minor: Please add a line of whitespace between method implementations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services