cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor
TaskContextImpl to not include access to objects that are only used internally
URL: https://github.com/apache/samza/pull/934#discussion_r261361532
##########
File path:
samza-core/src/test/java/org/apache/samza/operators/impl/TestOperatorImpl.java
##########
@@ -47,10 +48,12 @@
public class TestOperatorImpl {
private Context context;
+ private JobContextMetadata jobContextMetadata;
@Before
public void setup() {
this.context = new MockContext();
+ this.jobContextMetadata = new JobContextMetadata(null, null);
Review comment:
Consider mocking this object with Mockito instead of using a real instance.
It makes the test a bit more resilient to changes to JobContextMetadata in the
future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
