cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor
TaskContextImpl to not include access to objects that are only used internally
URL: https://github.com/apache/samza/pull/934#discussion_r261362340
##########
File path:
samza-core/src/test/java/org/apache/samza/operators/impl/TestWindowOperator.java
##########
@@ -436,13 +434,6 @@ public void testCancelationOfRepeatingNestedTriggers()
throws Exception {
@Test
public void testEndOfStreamFlushesWithEarlyTriggerFirings() throws Exception
{
- EndOfStreamStates endOfStreamStates = new
EndOfStreamStates(ImmutableSet.of(new SystemStreamPartition("kafka",
Review comment:
Just double checking: It looks like you removed some code but did not
replace it with anything. Was this code unnecessary for the test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
