> On Oct. 25, 2016, 9:31 p.m., Jagadish Venkatraman wrote: > > samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java, > > line 166 > > <https://reviews.apache.org/r/52492/diff/5/?file=1542707#file1542707line166> > > > > JobsClient seems to be a generic class and not really tied to any > > LocalStoreMonitor. Furthermore, we pass in an instance of the client to the > > monitor. > > > > For example, any other monitor that wants to make retriable requests > > could potentially use this. Can this be a separate class? > > Shanthoosh Venkataraman wrote: > There is no other monitor requiring this currently. It would make sense > to move this outside, once such a need arises.
0. `Could` another monitor use this? 1. Does this make sense to have a JobsClient instance in its independent entirety? (as opposed to being inside a LocalStoreMonitor). If a nested class would be useful in some other context, then maybe it should be a top-level class. 2. Is the JobsClient completely hidden outside the `LocalStoreMonitor`? Let's discuss this offline. - Jagadish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/#review153772 ----------------------------------------------------------- On Oct. 26, 2016, 12:41 a.m., Shanthoosh Venkataraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52492/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2016, 12:41 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > This patch contains the samza-rest monitor that periodically cleans up the > stale local stores of dead jobs/tasks. It performs the store deletion in two > phases. Initially it deletes the offset file in the local task stores if the > following condition is true. ((jobIsNotRunning || preferedHost != nmHost) && > offsetFilelastModifiedTime is greater than deleteRetention). During the > subsequent run, it deletes the local task stores if it does not contain > offset file. Please refer to the design doc of SAMZA-656 > (https://issues.apache.org/jira/secure/attachment/12828083/DESIGN-SAMZA-656.pdf) > for more details. > > > Diffs > ----- > > build.gradle 2bea27b75288d3103178bc3762b9556f6e69cdd1 > samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java > PRE-CREATION > > samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorConfig.java > PRE-CREATION > > samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorFactory.java > PRE-CREATION > > samza-rest/src/main/java/org/apache/samza/rest/resources/ResourceConstants.java > PRE-CREATION > > samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52492/diff/ > > > Testing > ------- > > Unit testing and manual testing are done to verify the functionality. > > > Thanks, > > Shanthoosh Venkataraman > >
