----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/#review152981 -----------------------------------------------------------
samza-rest/src/main/java/org/apache/samza/monitor/YarnLocalStoreMonitor.java (line 98) <https://reviews.apache.org/r/52492/#comment222185> nit: I think this would read better if demorgans law were applied samza-rest/src/main/java/org/apache/samza/monitor/YarnLocalStoreMonitor.java (line 99) <https://reviews.apache.org/r/52492/#comment222186> I see tests for the other 2 conditions, but not the preferredHost samza-rest/src/main/java/org/apache/samza/monitor/YarnLocalStoreMonitor.java (lines 164 - 166) <https://reviews.apache.org/r/52492/#comment222187> This class is still using YARN terminology when it is actually generic. Instead of RM hosts, we just want the hosts which support the Jobs and Tasks endpoints. JOB_STATUS_SERVERS, perhaps? samza-rest/src/main/java/org/apache/samza/monitor/YarnLocalStoreMonitorConfig.java (line 49) <https://reviews.apache.org/r/52492/#comment222193> Same in this class, do we really need to make this Yarn-specific or can we make it generic now? - Jake Maes On Oct. 13, 2016, 9:01 p.m., Shanthoosh Venkataraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52492/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 9:01 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > This patch contains the samza-rest monitor that periodically cleans up the > stale local stores of dead jobs/tasks. It performs the store deletion in two > phases. Initially it deletes the offset file in the local task stores if the > following condition is true. ((jobIsNotRunning || preferedHost != nmHost) && > offsetFilelastModifiedTime is greater than deleteRetention). During the > subsequent run, it deletes the local task stores if it does not contain > offset file. Please refer to the design doc of SAMZA-656 > (https://issues.apache.org/jira/secure/attachment/12828083/DESIGN-SAMZA-656.pdf) > for more details. > > > Diffs > ----- > > build.gradle 2bea27b75288d3103178bc3762b9556f6e69cdd1 > > samza-rest/src/main/java/org/apache/samza/monitor/YarnLocalStoreMonitor.java > PRE-CREATION > > samza-rest/src/main/java/org/apache/samza/monitor/YarnLocalStoreMonitorConfig.java > PRE-CREATION > > samza-rest/src/main/java/org/apache/samza/monitor/YarnLocalStoreMonitorFactory.java > PRE-CREATION > > samza-rest/src/main/java/org/apache/samza/rest/resources/ResourceConstants.java > PRE-CREATION > > samza-rest/src/test/java/org/apache/samza/monitor/TestYarnLocalStoreMonitor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52492/diff/ > > > Testing > ------- > > Unit testing and manual testing are done to verify the functionality. > > > Thanks, > > Shanthoosh Venkataraman > >
