----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51516/#review147518 -----------------------------------------------------------
docs/learn/documentation/versioned/container/metrics-table.html (line 367) <https://reviews.apache.org/r/51516/#comment214701> I think this metric just represents the number of partitions of a particular system that were empty and were provided to the consumer to poll for new messages. I don't think the correlation between $system-ssp-fetches-per-poll and $system-polls holds. Please correct me if I have misunderstood this. docs/learn/documentation/versioned/container/metrics-table.html (line 375) <https://reviews.apache.org/r/51516/#comment214703> nit: number of messages that were chosen (by the MessageChooser) for a particular system stream partition docs/learn/documentation/versioned/container/metrics-table.html (line 379) <https://reviews.apache.org/r/51516/#comment214705> nit: Average time spent polling all underlying systems for new messages (in nanoseconds) - Navina Ramesh On Aug. 30, 2016, 7:36 a.m., Branislav Cogic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51516/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 7:36 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-702 > https://issues.apache.org/jira/browse/SAMZA-702 > > > Repository: samza > > > Description > ------- > > All the metrics documented in a metrics-table. > > Few counters and timer removed because they are not used: > "send-calls" counter and "chooser-update-ns" timer from SamzaContainerMetrics > "batch-resets" counter from BootstrapingChooserMetrics > > > Diffs > ----- > > docs/_layouts/default.html 7beb734ddeaecb7a6369f7d2a5d4e0c67655269c > docs/learn/documentation/versioned/container/metrics-table.html > PRE-CREATION > docs/learn/documentation/versioned/container/metrics.md > b053b792097400536ea385cb3db720f6f71da017 > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala > 1e7515e8e8eb5ff2f769bea3184ce49308bada9a > > samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala > 1cd8e0637e2192460a9e9fe078c735444be8eb97 > > Diff: https://reviews.apache.org/r/51516/diff/ > > > Testing > ------- > > Site ran locally using local-site-test.sh > > > Thanks, > > Branislav Cogic > >
