----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51516/#review147506 -----------------------------------------------------------
Still going through the list. Thanks for compiling this. This is awesome work and super-useful for the Samza community! docs/learn/documentation/versioned/container/metrics-table.html (line 231) <https://reviews.apache.org/r/51516/#comment214696> Can you rephrase the description as "Number of commit method calls at TaskInstance level" so as to clearly distinguish it from Container's commit method call metrics? I understand it belongs to a different group. It will be better to distinguish them clearly. Or you can add a subtitle common to all metrics under "TaskInstanceMetrics" implying that the following apply to each TaskInstance docs/learn/documentation/versioned/container/metrics-table.html (line 243) <https://reviews.apache.org/r/51516/#comment214697> nit: "Number of messages actually processed by a task" docs/learn/documentation/versioned/container/metrics-table.html (line 247) <https://reviews.apache.org/r/51516/#comment214698> I actually don't see any difference between "send-calls" and "messages-sent". Both are technically the same. We should consider removing one of them. At least, deprecating one of them in the current version. - Navina Ramesh On Aug. 30, 2016, 7:36 a.m., Branislav Cogic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51516/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 7:36 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-702 > https://issues.apache.org/jira/browse/SAMZA-702 > > > Repository: samza > > > Description > ------- > > All the metrics documented in a metrics-table. > > Few counters and timer removed because they are not used: > "send-calls" counter and "chooser-update-ns" timer from SamzaContainerMetrics > "batch-resets" counter from BootstrapingChooserMetrics > > > Diffs > ----- > > docs/_layouts/default.html 7beb734ddeaecb7a6369f7d2a5d4e0c67655269c > docs/learn/documentation/versioned/container/metrics-table.html > PRE-CREATION > docs/learn/documentation/versioned/container/metrics.md > b053b792097400536ea385cb3db720f6f71da017 > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala > 1e7515e8e8eb5ff2f769bea3184ce49308bada9a > > samza-core/src/main/scala/org/apache/samza/system/chooser/BootstrappingChooser.scala > 1cd8e0637e2192460a9e9fe078c735444be8eb97 > > Diff: https://reviews.apache.org/r/51516/diff/ > > > Testing > ------- > > Site ran locally using local-site-test.sh > > > Thanks, > > Branislav Cogic > >
