----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33409/#review81527 -----------------------------------------------------------
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala <https://reviews.apache.org/r/33409/#comment131919> rename to mContainers and container-count samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala <https://reviews.apache.org/r/33409/#comment131916> nit spaces samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala <https://reviews.apache.org/r/33409/#comment131917> nit space samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala <https://reviews.apache.org/r/33409/#comment131918> nit space - Benjamin Fradet On April 24, 2015, 7:09 p.m., Benjamin Fradet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33409/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 7:09 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Renamed a few variables so the code is consistent and logic with naming > scheme used in Samza > > > Diffs > ----- > > samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 2b1aa3e > samza-yarn/src/main/scala/org/apache/samza/config/YarnConfig.scala 03395e2 > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala > ee2aa32 > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala > 8ba435e > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala > b0b6543 > > samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala > 4c855bf > > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala > 58f2464 > > Diff: https://reviews.apache.org/r/33409/diff/ > > > Testing > ------- > > Tested the `samza-yarn` submodule since it is the only one impacted > > > Thanks, > > Benjamin Fradet > >
