----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33409/#review81436 -----------------------------------------------------------
samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml <https://reviews.apache.org/r/33409/#comment131795> change taskId to containerId samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml <https://reviews.apache.org/r/33409/#comment131796> change to unclaimedContainer, finishedContainer. Also need to change that in SamzaAppMasterState class samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml <https://reviews.apache.org/r/33409/#comment131798> changing this to Task Group ID seems more clear samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml <https://reviews.apache.org/r/33409/#comment131797> This one was correct. Only need to change the state.runningTasks to state.runningContainers. (It's really confusing...*_*) The idea is that, one container can have multiple task(name)s. One container is though as "one task group" Task (group) Id is equal to "ContainerId" in Yarn's context. samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala <https://reviews.apache.org/r/33409/#comment131800> chaneg to unclaimedContainer and finishedContainer samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala <https://reviews.apache.org/r/33409/#comment131803> change to containerFailures, also ContainerFailure class samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala <https://reviews.apache.org/r/33409/#comment131805> change to unclaimedContainers accordingly samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala <https://reviews.apache.org/r/33409/#comment131806> so here it is containerId samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala <https://reviews.apache.org/r/33409/#comment131807> change accordingly samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala <https://reviews.apache.org/r/33409/#comment131808> using containerId seems better - Yan Fang On April 21, 2015, 8:57 p.m., Benjamin Fradet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33409/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 8:57 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Renamed a few variables so the code is consistent and logic with naming > scheme used in Samza > > > Diffs > ----- > > samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml 2b1aa3e > samza-yarn/src/main/scala/org/apache/samza/config/YarnConfig.scala 03395e2 > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala > ee2aa32 > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala > 8ba435e > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala > b0b6543 > > samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala > 4c855bf > > samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala > 58f2464 > > Diff: https://reviews.apache.org/r/33409/diff/ > > > Testing > ------- > > Tested the `samza-yarn` submodule since it is the only one impacted > > > Thanks, > > Benjamin Fradet > >
