----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31034/#review72871 -----------------------------------------------------------
samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java <https://reviews.apache.org/r/31034/#comment118992> Should this be null, not ""? samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java <https://reviews.apache.org/r/31034/#comment118999> Could be cleaned up a bit. serdeName = getStreamSerdeName if(serdeName == null) { serdeName = getSystemSerdeName } if(serdeName == null) { throw exception) } else { serdeClass = getSerdeClass(serdeName) // get serde factory, and get serde. } - Chris Riccomini On Feb. 18, 2015, 12:05 a.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31034/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 12:05 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-479 > https://issues.apache.org/jira/browse/SAMZA-479 > > > Repository: samza > > > Description > ------- > > modifed StreamAppender to accept different serdes > added LoggingEventStringSerde > added unit tests > > > Diffs > ----- > > samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java > 659e3b6 > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java > 9a9d648 > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/serializers/LoggingEventStringSerde.java > PRE-CREATION > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/serializers/LoggingEventStringSerdeFactory.java > PRE-CREATION > > samza-log4j/src/test/java/org/apache/samza/config/TestLog4jSystemConfig.java > 64a1e70 > > samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java > 46e4b8c > > samza-log4j/src/test/java/org/apache/samza/logging/log4j/serializers/TestLoggingEventStringSerde.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31034/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > >
