----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31034/#review72736 -----------------------------------------------------------
samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java <https://reviews.apache.org/r/31034/#comment118796> Can we just use the property from SerdeConfig? samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java <https://reviews.apache.org/r/31034/#comment118811> Nit: Should split this into a separate method to make it a little more legible. Should also use StreamConfig: val MSG_SERDE = STREAM_PREFIX + "samza.msg.serde" Resolution order is 1) stream config 2) system config 3) fail with exception. samza-log4j/src/main/java/org/apache/samza/logging/log4j/serializers/LoggingEventStringSerde.java <https://reviews.apache.org/r/31034/#comment118812> Javadoc. samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java <https://reviews.apache.org/r/31034/#comment118814> Add this as a default after SAMZA-554 is committed. - Chris Riccomini On Feb. 14, 2015, 12:38 a.m., Yan Fang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31034/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2015, 12:38 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-479 > https://issues.apache.org/jira/browse/SAMZA-479 > > > Repository: samza > > > Description > ------- > > modifed StreamAppender to accept different serdes > added LoggingEventStringSerde > added unit tests > > > Diffs > ----- > > samza-log4j/src/main/java/org/apache/samza/config/Log4jSystemConfig.java > 659e3b6 > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java > 9a9d648 > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/serializers/LoggingEventStringSerde.java > PRE-CREATION > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/serializers/LoggingEventStringSerdeFactory.java > PRE-CREATION > > samza-log4j/src/test/java/org/apache/samza/logging/log4j/TestStreamAppender.java > 46e4b8c > > samza-log4j/src/test/java/org/apache/samza/logging/log4j/serializers/TestLoggingEventStringSerde.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31034/diff/ > > > Testing > ------- > > > Thanks, > > Yan Fang > >
