I believe I have corrected all the anomalies that Greg commented on for the TDJ.
Hiedra
-----Mensaje original-----
De: Maria Jose Esteve <mjest...@iest.com>
Enviado el: miércoles, 30 de marzo de 2022 1:13
Para: dev@royale.apache.org
Asunto: RE: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC4
Test of TourDeJewel
---------------------------
There are some minor inconsistencies between ant and maven:
While both the maven and ant builds work, the ant build is
missing some runtime assets which the maven build is including (e.g. Jewel logo
in top left).
Error logging observed in js dev console:
Both builds show a runtime error when selecting the 'No
Submenu' menu option. This is a bug in TDJ itself, nothing to do with the SDK
build. Just noting it for attention...
The compilation of TourDeJewel with ant does not work as expected because it is
not copying the "Themes" to the target directory which causes errors accessing
the various resources that are needed: Jewel logo, Theme Change and other
images/icons. I will try to modify the build.xml file to include them.
At the same time, as I exposed in a previous post, the welcome page logo does
not resize correctly because of the ResponsiveSize bead (it does not run a
first time). I am going to upload some changes that I had in my branch and that
solves the problem (if someone doesn't see them correct, please tell me)
Hiedra
-----Mensaje original-----
De: Greg Dove <greg.d...@gmail.com<mailto:greg.d...@gmail.com>>
Enviado el: domingo, 27 de marzo de 2022 0:58
Para: Apache Royale Development
<dev@royale.apache.org<mailto:dev@royale.apache.org>>
Asunto: Re: [DISCUSS] Discuss Release Apache Royale 0.9.9 RC4
Just a couple of notes from me:
Future improvements in README
---------------------------------------------
playerglobal
I think the section on playerglobal should be re-written or removed. The links
to the original Adobe download appear to be no longer working (for download).
And I assume now that as Royale is generating its own playerglobal.swc (thanks
to Josh) it either needs to be updated to mention that, or the section removed
from README (as something that is
special-cased/noteworthy) because it is no longer relevant as an external
dependency.
Air
Download links do not work for Adobe AIR (but do provide information about
Harman). Should this section be updated?
Test of TourDeJewel
---------------------------
There are some minor inconsistencies between ant and maven:
While both the maven and ant builds work, the ant build is missing some runtime
assets which the maven build is including (e.g. Jewel logo in top left).
Error logging observed in js dev console:
Both builds show a runtime error when selecting the 'No Submenu' menu option.
This is a bug in TDJ itself, nothing to do with the SDK build. Just noting it
for attention...
On Fri, Mar 18, 2022 at 10:45 AM Josh Tynjala
<joshtynj...@bowlerhat.dev<mailto:joshtynj...@bowlerhat.dev>>
wrote:
> Hmmm... In RC4, I have now reproduced the ASDoc build issue that I
> mentioned previously, both with -Duse-flash=true and without it. Even
> without AIR_HOME being specified in the case of the JS-only build.
> However, it doesn't seem to reproduce every time. I guess that I just
> got unlucky when I was testing RC3, where it seemed to consistently
> affect the JS-only SDK. This time around, it seems to affect the
> JS+SWF SDK just as frequently on the same machine.
>
> Anyway, I agree with Alex that this issue doesn't need to block the
> release. I'm going to comment out the ASDoc example from the build,
> and if the approval script gets through everything else, I'm happy. I
> plan to vote
> +1, assuming that my remaining manual tests in VSCode and elsewhere
> +all
> look good too.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Thu, Mar 17, 2022 at 10:43 AM
> <apacheroyal...@gmail.com<mailto:apacheroyal...@gmail.com>> wrote:
>
> > This is the discussion thread.
> >
> > Thanks,
> > Yishay Weiss
>
