On Mon, 23 Sept 2024 at 20:37, Andrey Yegorov <andrey.yego...@datastax.com.invalid> wrote: > @Lari: I think we can simply use managedLedgerMaxUnackedRangesToPersist as > a limiter, as the state is already persisted with the cursor. > Adding another config to allow single entry/multi entry storage of the > state feels like unnecessary complication for the configuration, which is > not that easy to understand for users. > persistentUnackedRangesWithMultipleEntriesEnabled alerady used in > RangeSetWrapper and I don't think we should use it for other purposes.
The persistentUnackedRangesWithMultipleEntriesEnabled configuration property isn't really used for any real purpose at the moment. The current usage in `RangeSetWrapper` is part of the unfinished changes of PIP-81 that should be cleaned up. Since PIP-381 takes over PIP-81, I think it should be part of PIP-381 to handle this. I don't think we have to stop the vote for this reason, but I believe it's justified to have a feature flag for PIP-381. It would be natural to use persistentUnackedRangesWithMultipleEntriesEnabled as the feature flag for PIP-381. -Lari
