Hi,

Here is the pull request: https://github.com/apache/pulsar/pull/17508

Motivation:

When reformatting Java files, JAVADOC_STYLE cause the license header be
treated as doc comments and it will be affected from:

/**
 * ...
 * with the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * ...
 */

to

/**
 * ...
 * with the License.  You may obtain a copy of the License at
 * <p>
 * http://www.apache.org/licenses/LICENSE-2.0
 * <p>
 * Unless required by applicable law or agreed to in writing,
 * ...
 */

This is annoying and actually fails the license check, while we can replace
JAVADOC_STYLE with SLASHSTAR_STYLE and it won't be an issue anymore.

Especially after https://github.com/apache/pulsar/pull/18142 merged, we
globally enable checkstyle rules so that the action above will become more
and more frequent.

Looking forward to your feedback.

Best,
tison.

Reply via email to