[GitHub] [pulsar-dotpulsar] goldenccargill commented on a diff in pull request #104: add server timeout functionality plus docker test

[GitBox]

goldenccargill commented on code in PR #104:
URL: https://github.com/apache/pulsar-dotpulsar/pull/104#discussion_r888819496


##########
src/DotPulsar/Internal/Connection.cs:
##########
@@ -294,6 +298,11 @@ private async Task Send(BaseCommand command, 
CancellationToken cancellationToken
     }
 
     public async Task ProcessIncommingFrames(CancellationToken 
cancellationToken)
+    {
+        await Task.WhenAny(ProcessIncommingFramesImpl(cancellationToken), 
_pingPongHandler.ServerNotResponding);

Review Comment:
   done



##########
DotPulsar.sln:
##########
@@ -26,6 +26,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution 
Items", "Solution
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Processing", 
"samples\Processing\Processing.csproj", "{CC1494FA-4EB5-4DB9-8BE9-0A6E8D0D963E}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DotPulsar.Consumer", 
"tests\DotPulsar.Consumer\DotPulsar.Consumer.csproj", 
"{36E6E6EF-A471-4AE4-B696-1C9DAAFA2770}"

Review Comment:
   I need an executable that I can run in docker to connect to the server 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org