goldenccargill opened a new pull request, #104: URL: https://github.com/apache/pulsar-dotpulsar/pull/104
As mentioned in the keep alive section of the pulsar binary configuration [here](https://pulsar.apache.org/docs/v2.0.0-rc1-incubating/project/BinaryProtocol/) if the server stops responding to our pings when we have to assume the connection is no longer valid. We can't just rely on the transport to tell us if the connection is alive or not. I've implemented it based on any response from the server rather than specifically a pong, its open to debate if this is correct, I could go either way. I've also added a test to demonstrate the bug which is fixed by my code in the `PingPongHandler` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
