> The contributors found there are many places that might also have the same > problem.
I'm trying to understand "the problem" even though I haven't received replies from any of the contributors. For example, my question in https://github.com/apache/pulsar/issues/14013#issuecomment-1033528348 has been ignored. In the case of the "make async" changes, it seems to be about migrating from the blocking Servlet API to the Asynchronous Servlet API. For example this change: https://github.com/apache/pulsar/pull/14188/files#diff-0a1b84bf6bf3128bd4fc80875a959888ac68b989474afe536ac7cdd75d594400 There are a lot of these "make async" changes: https://github.com/apache/pulsar/pulls?q=is%3Apr+make+async . In Jetty documentation, there's an explanation about Asynchronous Servlets: https://wiki.eclipse.org/Jetty/Feature/Continuations#Why_Asynchronous_Servlets_.3F It also explains the benefits of asynchronous servlets: "The servlet API (<=2.5) supports only a synchronous call style, so that any waiting that a servlet needs to do must be with blocking. Unfortunately this means that the thread allocated to the request must be held during that wait along with all its resources: kernel thread, stack memory and often pooled buffers, character converters, EE authentication context, etc. It is wasteful of system resources to hold these resources while waiting. Significantly better scalability and quality of service can be achieved if waiting is done asynchronously." You can achieve better resource efficiency and better scalability with asynchronous servlets. Do we have such problems in Apache Pulsar with the Servlet API? -Lari On 2022/02/15 14:51:59 Lari Hotari wrote: > On 2022/02/15 14:13:59 PengHui Li wrote: > > The rationale for these changes, I think it starts from this PR > > https://github.com/apache/pulsar/pull/13666 > > This is the only one example, we have seen the same issue again and again. > > After #13666 get merged, > > The contributors found there are many places that might also have the same > > problem. > > Thanks for replying, Penghui. The problem is that there is no rationale nor > description in that PR, https://github.com/apache/pulsar/pull/13666 . The > only sentence there is "Avoid call sync method in async rest API for delete > subscription". > > > "we have seen the same issue again and again." > > What issue did you see? Please share more context. Thanks for the patience. > > BR, Lari >
