michaeljmarshall commented on a change in pull request #183:
URL: https://github.com/apache/pulsar-helm-chart/pull/183#discussion_r777832255
##########
File path: charts/pulsar/templates/dashboard-ingress.yaml
##########
@@ -19,7 +19,11 @@
{{- if .Values.extra.dashboard }}
{{- if .Values.dashboard.ingress.enabled }}
+{{- if semverCompare "<1.19-0" .Capabilities.KubeVersion.GitVersion }}
Review comment:
@wangshu3000 that definitely makes sense. I didn't know about the
feature's shortcoming, thanks for sharing. Otherwise, do you need to update it
to `KubeVersion.GitVersion` to `KubeVersion.Version`? We also need to figure
out why CI hasn't run for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
