michaeljmarshall commented on a change in pull request #183:
URL: https://github.com/apache/pulsar-helm-chart/pull/183#discussion_r777725211
##########
File path: charts/pulsar/templates/dashboard-ingress.yaml
##########
@@ -19,7 +19,11 @@
{{- if .Values.extra.dashboard }}
{{- if .Values.dashboard.ingress.enabled }}
+{{- if semverCompare "<1.19-0" .Capabilities.KubeVersion.GitVersion }}
Review comment:
@wangshu3000 - do you have a reference that documents `GitVersion`? I
don't see that in the helm documentation
(https://helm.sh/docs/chart_template_guide/builtin_objects/).
I think we should prefer the logic described in this stack overflow answer:
https://stackoverflow.com/a/66191437. Essentially, we can inspect the
`APIVersion` to see if the api has `networking.k8s.io/v1` and branch
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
