I think that any Pulsar committer ought to close any PR that is more than one 
year old. That would clear about 75 from the backlog. The OP should be informed 
and if they are still interested then they can discuss it here.

So when a stale PR is closed we should suggest that the OP subscribe to and 
email dev@pulsar.apache.org to discuss the PR.

All the Best,
Dave
.
> On Dec 3, 2021, at 9:17 AM, tison <wander4...@gmail.com> wrote:
> 
> From my experience, any process won't work. The only way is to inspire more
> reviewers act on PRs.
> 
> Instead of talking about how to do it, reviewing one PR now can help the
> case.
> Also, it's reasonable to close inactive PR if there is a successor. But do
> not let
> a bot do it, which will create many corner (bad) cases.
> 
> Best,
> tison.
> 
> 
> Michael Marshall <mmarsh...@apache.org> 于2021年12月4日周六 00:57写道:
> 
>> Hi Pulsar Community,
>> 
>> I am excited to start contributing as a committer! I have a question
>> about our process for closing stale PRs.
>> 
>> We have ~300 open PRs right now. Do we have any guidelines on closing
>> stale PRs? Of course we don't want to ignore important bug fixes, but
>> we also don't want to clutter our repo with open PRs that won't get merged.
>> 
>> For example, I reviewed this PR [0] about 3 months ago. The
>> contributor has not yet responded to my feedback and it doesn't seem
>> to fix an actual bug, so I think it is a candidate for closure. Here
>> is another example [1]. I closed this one because it had merge
>> conflicts with a commit that fixed the same underlying issue.
>> 
>> Note that our committer guidelines [2] do not provide guidance on this
>> subject.
>> 
>> [0] - https://github.com/apache/pulsar/pull/11237
>> [1] - https://github.com/apache/pulsar/pull/11162
>> [2] - https://github.com/apache/pulsar/wiki/Committer-Guide
>> 
>> Thanks,
>> Michael
>> 

Reply via email to