Hi Pulsar Community,

I am excited to start contributing as a committer! I have a question
about our process for closing stale PRs.

We have ~300 open PRs right now. Do we have any guidelines on closing
stale PRs? Of course we don't want to ignore important bug fixes, but
we also don't want to clutter our repo with open PRs that won't get merged.

For example, I reviewed this PR [0] about 3 months ago. The
contributor has not yet responded to my feedback and it doesn't seem
to fix an actual bug, so I think it is a candidate for closure. Here
is another example [1]. I closed this one because it had merge
conflicts with a commit that fixed the same underlying issue.

Note that our committer guidelines [2] do not provide guidance on this subject.

[0] - https://github.com/apache/pulsar/pull/11237
[1] - https://github.com/apache/pulsar/pull/11162
[2] - https://github.com/apache/pulsar/wiki/Committer-Guide

Thanks,
Michael

Reply via email to