Sorry for not being clear. My question is, when do we start requiring JDK11+ so that we can start using newer Java features in the Pulsar code base?
On Tue, Aug 31, 2021 at 9:23 AM Enrico Olivelli <eolive...@gmail.com> wrote: > Jonathan, > Pulsar 2.8 (and 2.9) builds well on JDK8 and JDK11. > Tests are passing. > Developers can use both JDK8 and JDK11. > CI is running ONLY on JDK11 and we have a single workflow that runs some > tests on JDK8. > The binary tarballs work with JDK8 and JDK11 > The Java client works with JDK8 and JDK11 > > The docker images are based on JDK11, so all the k8s users that use ASF > Pulsar Docker images run on JDK11 > > We should ensure that Pulsar runs and builds well on JDK17 but currently > there is no ongoing effort in the community > > Cheers > Enrico > > Il giorno mar 31 ago 2021 alle ore 15:22 Jonathan Ellis <jbel...@gmail.com > > > ha scritto: > > > What is the plan to fully move to JDK 11 (or JDK 17 which will be > released > > as LTS in two weeks)? > > > > I remember Enrico starting a thread in February but I haven't seen an > > update since then. > > > > On Tue, Aug 31, 2021 at 5:15 AM Hang Chen <chenh...@apache.org> wrote: > > > > > Hello Apache Pulsar Community, > > > In Apache Pulsar 2.8.1 RC1, Enrico found "check-binary-license" > > script > > > fails on the staged tarball > > > ``` > > > ~/dev/pulsar/src/check-binary-license apache-pulsar-2.8.1-bin.tar.gz > > > jetty-alpn-openjdk8-client-9.4.42.v20210604.jar unaccounted for in > > > lib/presto/LICENSE > > > jetty-alpn-java-client-9.4.42.v20210604.jar mentioned in > > > lib/presto/LICENSE, but not bundled > > > ``` > > > > > > After work with Enrico, he found jetty dependency > > > http2-http-client-transport adds transitive dependencies depending on > the > > > JDK version > > > > > > > > > https://repo1.maven.org/maven2/org/eclipse/jetty/http2/http2-http-client-transport/9.4.42.v20210604/http2-http-client-transport-9.4.42.v20210604.pom > > > > > > with jdk8: > > > > > > mvn dependency:tree > > > [INFO] | +- io.airlift:http-client:jar:0.195:compile > > > [INFO] | | +- > > org.eclipse.jetty:jetty-client:jar:9.4.42.v20210604:compile > > > [INFO] | | +- > > > org.eclipse.jetty.http2:http2-client:jar:9.4.42.v20210604:compile > > > [INFO] | | | \- > > > org.eclipse.jetty:jetty-alpn-client:jar:9.4.42.v20210604:compile > > > [INFO] | | +- > > > > > > > > > org.eclipse.jetty.http2:http2-http-client-transport:jar:9.4.42.v20210604:compile > > > [INFO] | | | \- > > > > org.eclipse.jetty:jetty-alpn-openjdk8-client:jar:9.4.42.v20210604:compile > > > [INFO] | | \- net.jodah:failsafe:jar:2.0.1:compile > > > > > > with jdk11: > > > > > > [INFO] | +- io.airlift:http-client:jar:0.195:compile > > > [INFO] | | +- > > org.eclipse.jetty:jetty-client:jar:9.4.42.v20210604:compile > > > [INFO] | | +- > > > org.eclipse.jetty.http2:http2-client:jar:9.4.42.v20210604:compile > > > [INFO] | | | \- > > > org.eclipse.jetty:jetty-alpn-client:jar:9.4.42.v20210604:compile > > > [INFO] | | +- > > > > > > > > > org.eclipse.jetty.http2:http2-http-client-transport:jar:9.4.42.v20210604:compile > > > [INFO] | | | \- > > > org.eclipse.jetty:jetty-alpn-java-client:jar:9.4.42.v20210604:compile > > > > > > In order to solve this issue, I will use JDK11 to release Apache Pulsar > > > 2.8.1 instead of JDK8. JDK11 is compatible with JDK8, and the release > > > target is specified to JDK8. > > > If you have any concerns, please let me know, thanks! > > > > > > Thanks for Enrico's great work. > > > > > > Thanks, > > > Hang > > > > > > > > > -- > > Jonathan Ellis > > co-founder, http://www.datastax.com > > @spyced > > > -- Jonathan Ellis co-founder, http://www.datastax.com @spyced
