dionjansen commented on a change in pull request #67:
URL: https://github.com/apache/pulsar-dotpulsar/pull/67#discussion_r558434707
##########
File path: src/DotPulsar/Internal/ConsumerChannel.cs
##########
@@ -108,6 +108,9 @@ public async Task Send(CommandAck command,
CancellationToken cancellationToken)
}
command.ConsumerId = _id;
+
+ _queue.Acknowledge(new MessageId(messageId));
Review comment:
Ok I addressed the MessageId issue by implementing the right interfaces
for comparison here 8841930, I'm not sure about the extension pattern for
MessageIdData though (using partials). I refactored the use of MessageIdData in
ad5827114c8d019aac86d300818b718ae8ab9d19 all tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
