dionjansen commented on a change in pull request #47:
URL: https://github.com/apache/pulsar-dotpulsar/pull/47#discussion_r446509650



##########
File path: src/DotPulsar/Internal/Consumer.cs
##########
@@ -104,6 +107,12 @@ public async ValueTask AcknowledgeCumulative(Message 
message, CancellationToken
         public async ValueTask AcknowledgeCumulative(MessageId messageId, 
CancellationToken cancellationToken)
             => await Acknowledge(messageId.Data, 
CommandAck.AckType.Cumulative, cancellationToken).ConfigureAwait(false);
 
+        public async ValueTask RedeliverUnacknowledgedMessages(List<MessageId> 
messageIds, CancellationToken cancellationToken)
+            => await RedeliverUnacknowledgedMessages(messageIds.Select(m => 
m.Data).ToList(), cancellationToken);
+
+        public async ValueTask 
RedeliverUnacknowledgedMessages(CancellationToken cancellationToken)
+            => await RedeliverUnacknowledgedMessages(new 
List<MessageIdData>(), cancellationToken);

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to