naruto-lgtm commented on PR #1525: URL: https://github.com/apache/poi/pull/1525#issuecomment-6626556421
Pushed a reworked version. The M1.11 check now walks a tree of the name segments, so it's linear in the name whatever is registered and uses memory linear in the registered names; the tree is transient and rebuilt after deserialization, and it compares names ignoring case like the rest of PackagePartName, which also fixes remove() with a different case. The test exercises PackagePartCollection.put directly and checks the work done rather than the time. Details are in the inline replies; the one-way check (M1.11 in reverse) is left for a follow-up as suggested. openxml4j, xwpf, xslf, ooxml, poifs, xssf and ss suites pass apart from the same font-metric cases as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
