jaragunde opened a new pull request, #1537:
URL: https://github.com/apache/poi/pull/1537

   Backport of #1534 to the 6.0.x branch. The squashed trunk commit fc26554ecf 
cherry-picked cleanly.
   
   POI 6.0.0 flips every shape horizontally and vertically when drawing, which 
renders non-grouped shapes rotated by 180°. The guards on the shapes' flip 
flags in `DrawShape.flipHorizontal()`/`flipVertical()` were lost in the 
refactoring in 1539088d. This backport:
   
   * restores the flip flag checks in `DrawShape`
   * fixes `HSLFShape.setFlipHorizontal()`/`setFlipVertical()`, which ignored 
their argument and always set the flag
   * adds `BaseTestDrawShape` with XSLF and HSLF subclasses, covering the flip 
states, a rotated flip and a flipped group
   
   Tested on 6.0.x: `TestXSLFDrawShape`, `TestDrawPictureShape` and 
`TestPPTX2PNG` in poi-ooxml, and all `org.apache.poi.hslf.*` tests in 
poi-scratchpad, pass.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to