We could revert r1721857 for 3.14 final, then reinstate it with fixes to the features it breaks plus unit tests after the release. Nothing in POI 3.14 depends on r1721857--it was solely a commit for correctness.
+1 from me. On Sat, Mar 5, 2016 at 12:43 PM, David North <dno...@apache.org> wrote: > Hi, > > I've now tested my projects with the release candidate - they were > already running against beta1. I found a couple of issues, though I > don't think either of them should block the release: > > (1) Javen's commit r1721857 broke a hack we had in place to allow us to > create our own default font. We should add a proper piece of API to > support this: https://bz.apache.org/bugzilla/show_bug.cgi?id=59127 > > (2) I notice that the full ooxml-schemas (and ooxml-security) released > by me during beta1 have the wrong xmlbeans dependency on Maven. I've > raised a bug to track: https://bz.apache.org/bugzilla/show_bug.cgi?id=59128 > > As I said, I don't think either of the above is a blocker (the second > one isn't usually a problem for reasons detailed on the bug), so +1 from > me to release. > > Thanks, > David > > > On 03/03/16 16:30, Dominik Stadler wrote: >> Hi, >> >> I see the following additions to the changelog: >> >> Excel: Allow to set multiple cell style properties at once >> Excel: Add API for inserting ignored warnings into XSSF sheets. This can be >> used e.g. to suppress 'number stored as text' warnings. >> Excel: New version of ooxml-schema and ooxml-security jars to incorporate >> newer code (or whatever the reason was for it, was it Visio-Support?) >> Common: Update third-party dependencies: commons-logging, commons-codec, >> xmlsec, bouncy-castly, ... >> >> >> One thing I saw is that the version-number in the "sonar" directory in the >> source-packages is not updated to "3.14", it still is at "3.14beta1". I >> don't think it is a big problem as these files are only used for running >> Sonar checks on apache hardware, but maybe we can update the release-guide >> and/or scripts to also set the version there when updating to the release >> version. >> >> >> Otherwise the packaged source looks fine, local tests with the binaries >> also look good >> >> So +1 from me >> >> Dominik. >> >> >> On Wed, Mar 2, 2016 at 1:26 PM, kiwiwings <kiwiwi...@apache.org> wrote: >> >>> Javen O'Neal wrote >>>> This was an insignificant change to POI, so I would omit it from the >>>> release notes. >>> >>> Is there something which I should highlight instead? >>> >>> I haven't reviewed those many changes and only use the assigned component >>> in >>> bugzilla >>> to find out where a patch was finally applied to (i.e. "ss common" for both >>> merged region fixes). >>> >>> Sorry for my ignorance and lack of involvement, but based on the headings >>> in >>> the changes page, >>> most changes look minor to me ... so please prove me wrong and of course I >>> will change the >>> announcement accordingly >>> >>> Andi >>> >>> >>> >>> >>> >>> -- >>> View this message in context: >>> http://apache-poi.1045710.n5.nabble.com/VOTE-Apache-POI-3-14-final-release-RC1-tp5722149p5722152.html >>> Sent from the POI - Dev mailing list archive at Nabble.com. >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org >>> For additional commands, e-mail: dev-h...@poi.apache.org >>> >>> >> > > -- > David North - Committer and PMC Member, Apache POI > https://home.apache.org/~dnorth/ > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
