----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62422/#review186502 -----------------------------------------------------------
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeCogroup.java Lines 661-662 (patched) <https://reviews.apache.org/r/62422/#comment263076> Only objects, lists and maps have to created a copy for a deep clone. Do not have to assign primitive types as super.clone() will take care of that. Same for other clone() implementations. src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeCogroupTez.java Lines 102 (patched) <https://reviews.apache.org/r/62422/#comment263075> Should be outside of reader.next() src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezCompiler.java Line 1115 (original), 1115 (patched) <https://reviews.apache.org/r/62422/#comment263270> Could you also add code to mark merge join, merge sparse join and merge cogroup in TezOperator and TezScriptState. Just realized that it is missing. - Rohini Palaniswamy On Sept. 27, 2017, 11:10 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62422/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 11:10 p.m.) > > > Review request for pig. > > > Bugs: PIG-4120 > https://issues.apache.org/jira/browse/PIG-4120 > > > Repository: pig-git > > > Description > ------- > > PIG-4120 Broadcast the index file in case of POMergeCoGroup and POMergeJoin > > > Diffs > ----- > > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeCogroup.java > f18d47a34 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeCogroupTez.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeJoin.java > 815a32586 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeJoinTez.java > PRE-CREATION > src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezCompiler.java > 79739e98a > src/org/apache/pig/impl/builtin/DefaultIndexableLoader.java a4688e499 > src/org/apache/pig/impl/builtin/TezIndexableLoader.java PRE-CREATION > test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MergeCogroup-1.gld > PRE-CREATION > test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MergeJoin-1.gld > PRE-CREATION > test/org/apache/pig/tez/TestTezCompiler.java f99d6f39c > > > Diff: https://reviews.apache.org/r/62422/diff/3/ > > > Testing > ------- > > > Thanks, > > Satish Saley > >
