----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62422/#review186748 -----------------------------------------------------------
src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezCompiler.java Lines 1232 (patched) <https://reviews.apache.org/r/62422/#comment263545> You need to mark merge join or merge spare join based on joinOp.joinType == LOJoin.JOINTYPE.MERGESPARSE src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeCogroupTez.java Lines 46 (patched) <https://reviews.apache.org/r/62422/#comment263546> private transient List<Pair<Integer, Tuple>> index; src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeCogroupTez.java Lines 98 (patched) <https://reviews.apache.org/r/62422/#comment263547> index = new LinkedList<>(); src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeJoin.java Lines 122-124 (original), 122-124 (patched) <https://reviews.apache.org/r/62422/#comment263550> Remove = -1. That will not stick as it is a transient variable and value will be 0 on deserializing. src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeJoin.java Line 126 (original), 126 (patched) <https://reviews.apache.org/r/62422/#comment263551> private static int ARRAY_LIST_SIZE = 1024; If transient, it will become 0 on deserializing. src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeJoinTez.java Lines 45 (patched) <https://reviews.apache.org/r/62422/#comment263552> private transient LinkedList<Tuple> index; In attachInputs, do index =new LinkedList<Tuple>(); test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MergeCogroup-1.gld Lines 13 (patched) <https://reviews.apache.org/r/62422/#comment263553> Can you add alias for the load operator of right side similar to merge join? It would be good to have this fixed. - Rohini Palaniswamy On Sept. 29, 2017, 9:13 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62422/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2017, 9:13 p.m.) > > > Review request for pig. > > > Bugs: PIG-4120 > https://issues.apache.org/jira/browse/PIG-4120 > > > Repository: pig-git > > > Description > ------- > > PIG-4120 Broadcast the index file in case of POMergeCoGroup and POMergeJoin > > > Diffs > ----- > > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeCogroup.java > f18d47a34 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeCogroupTez.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeJoin.java > 815a32586 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeJoinTez.java > PRE-CREATION > src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezCompiler.java > 79739e98a > src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezOperator.java > 6e99d395d > src/org/apache/pig/impl/builtin/DefaultIndexableLoader.java a4688e499 > src/org/apache/pig/impl/builtin/TezIndexableLoader.java PRE-CREATION > src/org/apache/pig/tools/pigstats/tez/TezScriptState.java 716f079b6 > test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MergeCogroup-1.gld > PRE-CREATION > test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MergeJoin-1.gld > PRE-CREATION > test/org/apache/pig/tez/TestTezCompiler.java f99d6f39c > > > Diff: https://reviews.apache.org/r/62422/diff/4/ > > > Testing > ------- > > > Thanks, > > Satish Saley > >
